Transfer - The runProducerConsumers method might terminate prematurely #1086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yahavi
changed the title
eyalbe4
approved these changes
Dec 22, 2023
4 tasks
eyalbe4
approved these changes
Dec 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on jfrog/gofrog#42.
Tests: jfrog/jfrog-cli#2384.
At times, the chunk uploader might have no upload tasks, resulting in setting the finish notification before all file uploads are completed. This could cause the runProducerConsumers to exit prematurely without finishing the uploading jobs.
When tasks are present in the queue without a polling task manager, it may lead to an increase in curProcessedUploadChunks without a corresponding decrease. This situation can escalate, especially when there are enough future upload tasks, potentially causing a deadlock by increasing curProcessedUploadChunks to the maximum number of allowed worker threads.
To resolve this, we reset the finish notification to ensure no remaining upload tasks after the subsequent finish notification.